Add AmericanFlagSort algorithm #6662
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implements American Flag Sort using bucket-based radix sort approach - Includes comprehensive test suite extending SortingAlgorithmTest - Follows project coding standards and documentation style
PauLopNun
requested review from
DenizAltunkapan,
alxkm and
yanglbme
as code owners
- Replace radix-based approach with generic bucket partitioning - Handle all data types: integers, floats, strings, custom objects - Support edge cases: NaN, Infinity, empty strings, mixed values - Use insertion sort for small arrays for better performance - Maintains O(n log n) average case complexity
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6662 +/- ##
============================================
+ Coverage 76.60% 76.65% +0.04%
- Complexity 6026 6043 +17
============================================
Files 719 720 +1
Lines 20326 20369 +43
Branches 3937 3946 +9
============================================
+ Hits 15571 15613 +42
Misses 4164 4164
- Partials 591 592 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Remove trailing spaces from lines 16, 30, 55, 59, 70, 80 - Improve code formatting for checkstyle compliance - Maintain same functionality and logic
- Change double spaces to single spaces before inline comments - Lines 56-58: Adjust comment spacing to match clang-format requirements - Maintain code readability and functionality
The CodeQL workflow failed due to a flaky BloomFilterTest, not related to AmericanFlagSort code. This empty commit triggers a re-run.
DenizAltunkapan
requested changes
Oct 11, 2025
There was a problem hiding this comment.
are you sure that this is american flag sort? The current implementation looks like a 3-way QuickSort (Dutch National Flag), not a true American Flag Sort.
There was a problem hiding this comment.
Consider adding explicit test cases for small arrays, already sorted arrays, reverse-sorted arrays, duplicates, and empty arrays to ensure correctness. You may want to add tests for null arrays or arrays with a single element to confirm that the algorithm handles these gracefully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-format -i --style=file path/to/your/file.java